filipf added a comment.
In D15999#368500 <https://phabricator.kde.org/D15999#368500>, @ngraham wrote: > In D15999#368499 <https://phabricator.kde.org/D15999#368499>, @filipf wrote: > > > But there is a tangible problem here - imagine what the logout screen when using dark themes would look like if the circles were dark[;] They would be weird looking and would be superfluous. > > > That's precisely why I wanted a subtle outline around the edge of the background circle, which earlier versions had. With that, a dark circle on a dark wallpaper didn't become muddy and fade into the wallpaper; it still looked crisp and handsome. In D15999#368500 <https://phabricator.kde.org/D15999#368500>, @ngraham wrote: > In D15999#368499 <https://phabricator.kde.org/D15999#368499>, @filipf wrote: > > > But there is a tangible problem here - imagine what the logout screen when using dark themes would look like if the circles were dark[;] They would be weird looking and would be superfluous. > > > That's precisely why I wanted a subtle outline around the edge of the background circle, which earlier versions had. With that, a dark circle on a dark wallpaper didn't become muddy and fade into the wallpaper; it still looked crisp and handsome. I've made a **very** rough sketch (apologies for the roughness) to test things out. It's not that bad. F6448064: logoutnostroke.png <https://phabricator.kde.org/F6448064> Obviously it's a bit better when there's strokes: F6448068: logoutwstroke.png <https://phabricator.kde.org/F6448068> Though I have to admit I usually find strokes and outlines to be visually detrimental; in this case they also sort of overwhelm me because my brain is saying "there's too many lines". I also don't like how they're not of the same color as the icon itself, whereas if you make them white they will poke your eyes out. But there is a more important thing white circles would have going for them - how obvious it is which logout option is selected (which was also one of the reasons behind adding circles). A dark circle having its opacity lowered on a dark background is just less effective than a white circle on a dark background. So tl;dr = I still think white circles with dark themes are a better choice in the case of the logout screen. When it comes to SDDM, a lot of our problems stem from how uncustomizable it is... but what Phil said, if it could somehow detect the darkness of the wallpaper and adjust icons (maybe even other elements?) appropriately, that would be fantastic. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg, ndavis Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns
