meven added a comment.
In D22143#502476 <https://phabricator.kde.org/D22143#502476>, @meven wrote: > In D22143#502336 <https://phabricator.kde.org/D22143#502336>, @kossebau wrote: > > > In D22143#502314 <https://phabricator.kde.org/D22143#502314>, @meven wrote: > > > > > > Relying on undocumented names of generated sources files does not get my +1. That needs someone else to take responsibility :) > > > > > > Well this kind of file generation is common and is indirectly documented through the ecm_qt_declare_logging_category macro. > > > > > > The current implementation of the macro is an internal detail. It is not part of the API contract. > > > I am quoting the macro documentation : > > > A header file, <filename>, will be generated along with a corresponding source file, ... > > https://api.kde.org/ecm/module/ECMQtDeclareLoggingCategory.html > > So here, It seems to me this generated cpp file is part of the macro documented behavior. With this and my added comment on line 21 of autotests/CMakeLists.txt What do you think @kossebau ? REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22143 To: meven, ivan, #frameworks, kossebau Cc: kossebau, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
