sitter added inline comments. INLINE COMMENTS
> dfaure wrote in kio_smb_mount.cpp:72 > (pre-existing: shouldn't this call `error` rather than `finished`?) Ah yes, I was thinking the same thing but didn't manage to find a reasonable way to use this feature so it's hard to test. I'll write my own demo app I guess. REPOSITORY R320 KIO Extras BRANCH Applications/19.08 REVISION DETAIL https://phabricator.kde.org/D24387 To: sitter, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov