-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106863/
-----------------------------------------------------------

Review request for Solid.


Description
-------

That message usually appears when starting before the Desktop is up, causing an 
ugly 1990's passivepopup dialog on the screen, and its contents are not really 
novice-user-resolvable.
On my machine it always claims "The profile Battery tried to activate 
DPMSControl which is a non-existent action.", which is when I compile 
powerdevil myself that DPMS stuff is not compiled (DPMS build requirements not 
met here) and so the action floats around in the config but cannot be triggered 
anyways. (Imho this is a really infamous message, have seen it quite often on 
other machines *duck*). All the other actions seem to be installed anyways, so 
this missing action poses no threat. I guess a kWarning would be sufficient for 
this.


Diffs
-----

  powerdevil/daemon/powerdevilcore.cpp 058bfc6 

Diff: http://git.reviewboard.kde.org/r/106863/diff/


Testing
-------

Compiles.
The previous passivepopup does not appear anymore. Did not test whether the 
kwarning is triggered, though. (Dunno how to get powerdevil debug console 
output)


Thanks,

Kai Uwe Broulik

_______________________________________________
Kde-hardware-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Reply via email to