----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101419/#review3639 -----------------------------------------------------------
libs/ui/vpnuiplugin.h <http://git.reviewboard.kde.org/r/101419/#comment3027> I think importConnectionSettings sounds better than importConnectionDetails. settings/config/manageconnectionwidget.cpp <http://git.reviewboard.kde.org/r/101419/#comment3025> "Import VPN connection settings" as last argument. settings/config/manageconnectionwidget.cpp <http://git.reviewboard.kde.org/r/101419/#comment3026> "Could not import VPN connection settings" settings/config/manageconnectionwidget.cpp <http://git.reviewboard.kde.org/r/101419/#comment3024> Change this to "VPN connection successfuly exported". Not all people will figure out at first glance that this imports/exports VPN connection settings. - Lamarque Vieira On June 2, 2011, 7:09 p.m., Rajeesh K Nambiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101419/ > ----------------------------------------------------------- > > (Updated June 2, 2011, 7:09 p.m.) > > > Review request for Network Management. > > > Summary > ------- > > First stab at VPN connection import/export functionality. Currently > implemented just VPNC Import support. Please review, especially the > VpncUiPluginPrivate part which tries to abstract away cisco password decrypt > function. If the general approach looks good, I'll proceed with this and try > to extend for other VPN methods, as well as export function. > > > This addresses bug 146159. > http://bugs.kde.org/show_bug.cgi?id=146159 > > > Diffs > ----- > > libs/ui/vpnpreferences.cpp 843636c > libs/ui/vpnuiplugin.h 7a13027 > settings/config/CMakeLists.txt 268c23b > settings/config/addeditdeletebuttonset.h f7abef7 > settings/config/addeditdeletebuttonset.cpp 4f3f97a > settings/config/manageconnectionwidget.h 51f60a0 > settings/config/manageconnectionwidget.cpp fdd350b > vpnplugins/novellvpn/novellvpn.h 9e026e2 > vpnplugins/novellvpn/novellvpn.cpp 848b527 > vpnplugins/openvpn/openvpn.h a06b88e > vpnplugins/openvpn/openvpn.cpp 60376ed > vpnplugins/pptp/pptp.h 66ea79a > vpnplugins/pptp/pptp.cpp c311f9f > vpnplugins/strongswan/strongswan.h fcd5bde > vpnplugins/strongswan/strongswan.cpp 5bffc2b > vpnplugins/vpnc/nm-vpnc-service.h e3f859a > vpnplugins/vpnc/vpnc.h aec2136 > vpnplugins/vpnc/vpnc.cpp deb9108 > > Diff: http://git.reviewboard.kde.org/r/101419/diff > > > Testing > ------- > > Tested against latest git snapshot, with KDE SC 4.6.3 > > > Thanks, > > Rajeesh > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
