Pazar 22 Mayıs 2011 günü (saat 16:30:36) Rajeesh K Nambiar şunları yazmıştı: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101419/ > ----------------------------------------------------------- > > Review request for Network Management. >
In ManageConnectionWidget::tabChanged method, that patch adds those lines: connect(mConnEditUi.buttonSetVpn->importButton(),SIGNAL(clicked()),SLOT(importClicked())); connect(mConnEditUi.buttonSetVpn->exportButton(),SIGNAL(clicked()),SLOT(exportClicked())); so every time we switch to VPN tab, another connection is established for clicked() signal. As a result; after a few tab changes, several Import dialogs appear one after another when the Import button of VPN is clicked. I'll commit attached patch, if everyone is OK. -- Gökçen Eraslan
diff --git a/settings/config/manageconnectionwidget.cpp b/settings/config/manageconnectionwidget.cpp
index a68990d..9593b24 100644
--- a/settings/config/manageconnectionwidget.cpp
+++ b/settings/config/manageconnectionwidget.cpp
@@ -896,14 +896,14 @@ void ManageConnectionWidget::tabChanged(int index)
mVpnMenu->addAction(vpnAction);
}
connect(mVpnMenu, SIGNAL(triggered(QAction*)), SLOT(connectionTypeMenuTriggered(QAction*)));
+ connect(mConnEditUi.buttonSetVpn->importButton(),SIGNAL(clicked()),SLOT(importClicked()));
+ connect(mConnEditUi.buttonSetVpn->exportButton(),SIGNAL(clicked()),SLOT(exportClicked()));
mConnEditUi.buttonSetVpn->addButton()->setMenu(mVpnMenu);
}
mConnEditUi.buttonSetVpn->addButton()->setEnabled(!mVpnMenu->isEmpty());
mConnEditUi.buttonSetVpn->importButton()->setEnabled(!mVpnMenu->isEmpty());
mConnEditUi.buttonSetVpn->importButton()->setVisible(!mVpnMenu->isEmpty());
mConnEditUi.buttonSetVpn->exportButton()->setVisible(!mVpnMenu->isEmpty());
- connect(mConnEditUi.buttonSetVpn->importButton(),SIGNAL(clicked()),SLOT(importClicked()));
- connect(mConnEditUi.buttonSetVpn->exportButton(),SIGNAL(clicked()),SLOT(exportClicked()));
}
}
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
