----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101419/#review3652 -----------------------------------------------------------
settings/config/manageconnectionwidget.cpp <http://git.reviewboard.kde.org/r/101419/#comment3035> At least for now I am assuming VPN connections are always user scope. User scope in NM-0.9 is different from NM-0.8: in NM-0.8 there is one DBus interface for each scope, so in Plasma NM-0.8 we have two objects, one for each interface. Furthermore the connection settings and secrets are stored or in system (/etc/NetworkManager/system-connections) or in user (~/.kde/share/apps/networkmanagement/connections) side. In NM-0.9 there is only one DBus interface and only the secrets are stored in system or user side (AgentOwned in NM-0.9 terminology). The settings are always saved in system side (/etc/NetworkManager/system-connections). That all means you do not need to check the scope here, just save all secrets as AgentOwned and that is it. When you do it please add a comment saying you are assuming the secrets are AgentOnwed. I still not figure out how to have system wide VPN connections, so maybe in the future I will have to change that and the comment will make life easier to find where to find in the source code. vpnplugins/vpnc/vpnc.cpp <http://git.reviewboard.kde.org/r/101419/#comment3036> You also need to add entries like: "ipsec-secret-type" -> "save" "IPSec secret-flags" -> "0" "xauth-password-type" -> "ask" "Xauth password-flags" -> "2" To indicate where the secrets are going to be saved. Look at how VpnSetting::data() in libs/internals/settings/vpn.h does it for example. The integer values above (0, 2 in the examples) are of type secretsTypes and should alwas be "Or"ed with AgentOwned value (1), look at VpnSetting::storageTypeToSecretsType() does it. That should be done for all secrets. - Lamarque Vieira On June 3, 2011, 6:43 p.m., Rajeesh K Nambiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101419/ > ----------------------------------------------------------- > > (Updated June 3, 2011, 6:43 p.m.) > > > Review request for Network Management. > > > Summary > ------- > > First stab at VPN connection import/export functionality. Currently > implemented just VPNC Import support. Please review, especially the > VpncUiPluginPrivate part which tries to abstract away cisco password decrypt > function. If the general approach looks good, I'll proceed with this and try > to extend for other VPN methods, as well as export function. > > > This addresses bug 146159. > http://bugs.kde.org/show_bug.cgi?id=146159 > > > Diffs > ----- > > libs/internals/settings/vpnsecrets.h 96803ec > libs/ui/vpnpreferences.cpp 843636c > libs/ui/vpnuiplugin.h 7a13027 > settings/config/CMakeLists.txt 783d551 > settings/config/addeditdeletebuttonset.h f7abef7 > settings/config/addeditdeletebuttonset.cpp 4f3f97a > settings/config/manageconnectionwidget.h 41a449c > settings/config/manageconnectionwidget.cpp db69cb6 > vpnplugins/novellvpn/novellvpn.h 9e026e2 > vpnplugins/novellvpn/novellvpn.cpp 848b527 > vpnplugins/openvpn/openvpn.h a06b88e > vpnplugins/openvpn/openvpn.cpp 60376ed > vpnplugins/pptp/pptp.h 66ea79a > vpnplugins/pptp/pptp.cpp c311f9f > vpnplugins/strongswan/strongswan.h fcd5bde > vpnplugins/strongswan/strongswan.cpp 5bffc2b > vpnplugins/vpnc/nm-vpnc-service.h e3f859a > vpnplugins/vpnc/vpnc.h aec2136 > vpnplugins/vpnc/vpnc.cpp deb9108 > > Diff: http://git.reviewboard.kde.org/r/101419/diff > > > Testing > ------- > > Tested against latest git snapshot, with KDE SC 4.6.3 > > > Thanks, > > Rajeesh > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
