> On July 17, 2011, 8:07 p.m., Francesco Nwokeka wrote: > > Doesn't this trigger the account to go online twice when first creating it?
It shouldn't, that slot is called only when the checkbox is clicked, not when the account is enabled for other reasons. - Paolo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101980/#review4779 ----------------------------------------------------------- On July 17, 2011, 6 p.m., Paolo Capriotti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101980/ > ----------------------------------------------------------- > > (Updated July 17, 2011, 6 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > As discussed on IRC: > > [18:13] <pcapriotti> the only question left, then, is whether we want the > account to go online when we disable and reenable > [18:13] <d_ed> I'm fine with it. > [18:13] <d_ed> I think it's a good idea, the user has made a concious action, > they can't be surprised when it reconnects. > > > Diffs > ----- > > src/kcm-telepathy-accounts.cpp 26e5f0b > > Diff: http://git.reviewboard.kde.org/r/101980/diff > > > Testing > ------- > > open KCM, disable, reenable -> account online > > > Thanks, > > Paolo > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
