----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101980/#review4857 -----------------------------------------------------------
Ship it! [12:43] <mck182> although I'm still all for a checkbox, but I'm willing to step back on this one Enough bikeshedding already. Ship it, if it sucks we change it later. - David On July 17, 2011, 6 p.m., Paolo Capriotti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101980/ > ----------------------------------------------------------- > > (Updated July 17, 2011, 6 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > As discussed on IRC: > > [18:13] <pcapriotti> the only question left, then, is whether we want the > account to go online when we disable and reenable > [18:13] <d_ed> I'm fine with it. > [18:13] <d_ed> I think it's a good idea, the user has made a concious action, > they can't be surprised when it reconnects. > > > Diffs > ----- > > src/kcm-telepathy-accounts.cpp 26e5f0b > > Diff: http://git.reviewboard.kde.org/r/101980/diff > > > Testing > ------- > > open KCM, disable, reenable -> account online > > > Thanks, > > Paolo > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
