> On March 23, 2014, 8:19 a.m., David Edmundson wrote: > > KTp/Declarative/presence-manager.h, line 50 > > <https://git.reviewboard.kde.org/r/116880/diff/1/?file=256034#file256034line50> > > > > why are we starting an enum here? > > Siddhartha Sahu wrote: > User defined enums should start at Qt::UserRole, shouldn't they?
No. Only when extending model roles > On March 23, 2014, 8:19 a.m., David Edmundson wrote: > > KTp/Declarative/presence-manager.h, line 60 > > <https://git.reviewboard.kde.org/r/116880/diff/1/?file=256034#file256034line60> > > > > In general properties with read/write make better QML than Q_INVOKABLE > > Siddhartha Sahu wrote: > I got as far as Q_PROPERTY(ConnectionPresenceType presence READ presence > WRITE setPresence) > 1) How to make this write only? > 2) Is ConnectionPresenceType the correct type to use here? add a read property too? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116880/#review53781 ----------------------------------------------------------- On March 21, 2014, 6:44 p.m., Siddhartha Sahu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116880/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 6:44 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > [Work in progress] > > This adds a PresenceManager class to Declarative code that can be used from > QML to get and set global presence. > > > Diffs > ----- > > KTp/Declarative/presence-manager.cpp PRE-CREATION > KTp/Declarative/presence-manager.h PRE-CREATION > KTp/Declarative/CMakeLists.txt 57025536af43279d31380f32a2827e4060686fdc > KTp/Declarative/qml-plugins.cpp bc134e0dcb35ebd323dee5164a8ce5ae5537dd75 > > Diff: https://git.reviewboard.kde.org/r/116880/diff/ > > > Testing > ------- > > Is accessible from ktp-active, functions called successfully with parameters > > > Thanks, > > Siddhartha Sahu > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
