> On April 6, 2014, 5:35 p.m., David Edmundson wrote: > > KTp/Declarative/presence-manager.h, line 67 > > <https://git.reviewboard.kde.org/r/116880/diff/3/?file=262577#file262577line67> > > > > This isn't the best signal name. As it implies one single account is > > ready. > > Does anything actually use this? Either rename or delete it.
Sorry, this should be accountManagerReady. This is used to tell KTp Active that presences can now be set and retrieved. - Siddhartha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116880/#review55063 ----------------------------------------------------------- On April 6, 2014, 11:27 p.m., Siddhartha Sahu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116880/ > ----------------------------------------------------------- > > (Updated April 6, 2014, 11:27 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > This adds a PresenceManager class to Declarative code that can be used from > QML to get and set global presence. > > > Diffs > ----- > > KTp/global-presence.cpp 0f08509529db9a9ce8ec27666bb97b9b6e34d098 > KTp/global-presence.h 1bba3fc692ee1b85eb93a7a3b4a01ba7b6402fbd > KTp/Declarative/qml-plugins.cpp bc134e0dcb35ebd323dee5164a8ce5ae5537dd75 > > Diff: https://git.reviewboard.kde.org/r/116880/diff/ > > > Testing > ------- > > Is accessible from ktp-active, functions called successfully with parameters > > > Thanks, > > Siddhartha Sahu > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
