----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116880/#review54558 -----------------------------------------------------------
GlobalPresence also supports setting a presence message, do you have any plans for that? KTp/Declarative/presence-manager.h <https://git.reviewboard.kde.org/r/116880/#comment38159> Is there a reason we copy this from tp-qt? Can we just do Q_ENUMS(Tp::ConnectionPresenceType) (if it's not already)? KTp/Declarative/presence-manager.h <https://git.reviewboard.kde.org/r/116880/#comment38160> this should be const KTp/Declarative/presence-manager.cpp <https://git.reviewboard.kde.org/r/116880/#comment38161> Try to minimize the debug output as much as possible, this is not a very useful for anyone except the developer (and it's perfectly fine to have loads of kDebugs locally). - Martin Klapetek On March 29, 2014, 5:30 p.m., Siddhartha Sahu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116880/ > ----------------------------------------------------------- > > (Updated March 29, 2014, 5:30 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > [Work in progress] > > This adds a PresenceManager class to Declarative code that can be used from > QML to get and set global presence. > > > Diffs > ----- > > KTp/Declarative/qml-plugins.cpp bc134e0dcb35ebd323dee5164a8ce5ae5537dd75 > KTp/Declarative/presence-manager.cpp PRE-CREATION > KTp/Declarative/presence-manager.h PRE-CREATION > KTp/Declarative/CMakeLists.txt 57025536af43279d31380f32a2827e4060686fdc > > Diff: https://git.reviewboard.kde.org/r/116880/diff/ > > > Testing > ------- > > Is accessible from ktp-active, functions called successfully with parameters > > > Thanks, > > Siddhartha Sahu > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
