> On April 6, 2014, 10:10 a.m., James Smith wrote: > > status-handler.cpp, lines 355-357 > > <https://git.reviewboard.kde.org/r/116940/diff/7/?file=262945#file262945line355> > > > > Should this have AutoConnect save the presence?
I think leaving both loading and saving in StatusHandler is probably the best solution. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116940/#review55055 ----------------------------------------------------------- On April 5, 2014, 10:36 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116940/ > ----------------------------------------------------------- > > (Updated April 5, 2014, 10:36 a.m.) > > > Review request for Telepathy. > > > Bugs: 332082 > http://bugs.kde.org/show_bug.cgi?id=332082 > > > Repository: ktp-kded-module > > > Description > ------- > > Fixes engage-nowPlaying-from-custom-status-message and lessens disk activity > on presence change. Also simplifies logic used to keep telepathy-kded-module > in a "fit" state during run-time. > > > Diffs > ----- > > status-handler.h 06240ff > status-handler.cpp 4b9c25a > telepathy-kded-module-plugin.h 4c16169 > > Diff: https://git.reviewboard.kde.org/r/116940/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
