----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116940/#review57615 -----------------------------------------------------------
status-handler.cpp <https://git.reviewboard.kde.org/r/116940/#comment40069> Instead of having the extra method setPluginEnabled which doesn't have the signal we could change this to a Qt::QueuedConnection. This way it would only run after all the plugins are finished being disabled and therefore not do anything. status-handler.cpp <https://git.reviewboard.kde.org/r/116940/#comment40068> If we have: Now playing Then AutoAway starts Then AutoAway ends we're no longer in now playing. telepathy-kded-module-plugin.h <https://git.reviewboard.kde.org/r/116940/#comment40070> I'm still not allowing a second very similarly named setMethod() that behaves slightly differently. It's confusing API telepathy-mpris.cpp <https://git.reviewboard.kde.org/r/116940/#comment40066> Why do we have enabled active and enabledInConfig as 3 completely separate things? Surely 1 of these must be pointless. telepathy-mpris.cpp <https://git.reviewboard.kde.org/r/116940/#comment40067> Surely, this wouldn't be needed if you hadn't changed line 274 Changing it clearly complicates things - David Edmundson On May 8, 2014, 10:39 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116940/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 10:39 a.m.) > > > Review request for Telepathy. > > > Bugs: 332082 and 334492 > http://bugs.kde.org/show_bug.cgi?id=332082 > http://bugs.kde.org/show_bug.cgi?id=334492 > > > Repository: ktp-kded-module > > > Description > ------- > > This patch returns the ability to engage status message plug-ins from custom > status messages. Also working is the disabling of non-visible status message > plug-ins. State-affinity in the 95% of previously noted cases has been vastly > improved also, the few remaining issues should be due to "lite" protocols > that don't have a full complement of on-line presences. > > > Diffs > ----- > > status-handler.h 06240ff > status-handler.cpp 4b9c25a > telepathy-kded-module-plugin.h 4c16169 > telepathy-kded-module-plugin.cpp daf73c6 > telepathy-mpris.cpp 69e8562 > > Diff: https://git.reviewboard.kde.org/r/116940/diff/ > > > Testing > ------- > > Disconnect / reconnect, autoconnect / no autoconnect, suspend / resume. > Enable / disable via kcm module. Added a new custom presence and engaged the > now playing plugin in the contact list from the new presence. Disabled the > plugin by activating another presence. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
