> On May 7, 2014, 10:37 p.m., David Edmundson wrote: > > telepathy-kded-module-plugin.cpp, line 52 > > <https://git.reviewboard.kde.org/r/116940/diff/10/?file=271956#file271956line52> > > > > We do not need > > > > setEnabled > > setActive > > > > AND > > > > setPluginEnabled > > > > The only difference between this and setenabled is that it doesn't emit > > a signal. > > Except you only call it when its inactive so that won't matter anyway. > > James Smith wrote: > This allows smooth presence changes that don't bounce back to the > presence prior to the status message plugin being engaged. > > James Smith wrote: > Unexplained unexpected selection deviation a bug. This code is easier to > read to find what problems are caused by what area, and many presence > problems are easily dismissed by explaining what the plugins are not doing by > not signaling unexpectedly and breaking the expected outcome.
> Unexplained unexpected selection deviation a bug. Can we try to stick to simpler sentences please. Not everyone here is a native English speaker. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116940/#review57536 ----------------------------------------------------------- On May 8, 2014, 10:39 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116940/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 10:39 a.m.) > > > Review request for Telepathy. > > > Bugs: 332082 and 334492 > http://bugs.kde.org/show_bug.cgi?id=332082 > http://bugs.kde.org/show_bug.cgi?id=334492 > > > Repository: ktp-kded-module > > > Description > ------- > > This patch returns the ability to engage status message plug-ins from custom > status messages. Also working is the disabling of non-visible status message > plug-ins. State-affinity in the 95% of previously noted cases has been vastly > improved also, the few remaining issues should be due to "lite" protocols > that don't have a full complement of on-line presences. > > > Diffs > ----- > > status-handler.h 06240ff > status-handler.cpp 4b9c25a > telepathy-kded-module-plugin.h 4c16169 > telepathy-kded-module-plugin.cpp daf73c6 > telepathy-mpris.cpp 69e8562 > > Diff: https://git.reviewboard.kde.org/r/116940/diff/ > > > Testing > ------- > > Disconnect / reconnect, autoconnect / no autoconnect, suspend / resume. > Enable / disable via kcm module. Added a new custom presence and engaged the > now playing plugin in the contact list from the new presence. Disabled the > plugin by activating another presence. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
