Thanks Emmanuel. The user would have to add zookeeper/nimbus in the poms before generating the distribution to add them, so I am going to remove these from the NOTICE file as they are not required.
OK here are the changes I have made...please review: 1) The root NOTICE just includes the standard Apache copyright notice: https://github.com/apache/directory-kerby/blob/trunk/NOTICE 2) The two "distributions" of "kdc-dist" and "tool-dist" have the following NOTICE files: https://github.com/apache/directory-kerby/blob/trunk/kerby-dist/kdc-dist/NOTICE https://github.com/apache/directory-kerby/blob/trunk/kerby-dist/tool-dist/NOTICE and the following identical license folders: https://github.com/apache/directory-kerby/tree/trunk/kerby-dist/tool-dist/licenses https://github.com/apache/directory-kerby/tree/trunk/kerby-dist/kdc-dist/licenses We only bundle Netty + SLF4J in "kdc-dist" and only SLF4J in the tool-dist, so I think we are covered. Colm. -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com On Tue, May 9, 2017 at 11:04 AM, Emmanuel Lécharny <elecha...@gmail.com> wrote: > > > Le 09/05/2017 à 11:16, Colm O hEigeartaigh a écrit : > > OK, seeing as we don't bundle them by default, then IMO we don't need to > > include them in the NOTICE file. Emmanuel, can you confirm? > Everything that is not bundled does not have to be into N&L files. > > If there is no way a user can grab the sources and generate a package > from those source that contain this bundle, then there is no need to > have the N&L file in the source either. OTOH, if the user can grab the > source, build it to produce a package that will contain the bundle, then > we need teh N&L files somwhere so that they get added when the user > build the packaged. In any case, it should not be present in our source > package N&L. > > To be very clear : there are two kinds of N&L files : > - those we include in our source or binary packages (if we provide some). > - those that get included when we generate some packages from the source > package (they are 'second order' N&L files) > > The first category makes our package legit, teh second category protect > our users when they build their own package using our build system > (typically the 'dist' modules). > > -- > Emmanuel Lecharny > > Symas.com > directory.apache.org > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
