Hi Kai, What matters is what jars we are including in the "lib". Any changes Netty made to third party dependencies in these jars must be in the NOTICE/licenses.
Colm. On Tue, May 9, 2017 at 1:20 PM, Zheng, Kai <[email protected]> wrote: > Hi Colm and Emmanuel, > > Regarding Netty, what we used is the TCP/UDP network transport support, > which should be one of its basic functionalities. We haven't used any other > parts, like the one JBoss marshalling function. The relevant codes are in > kerby KDC. Hope this helps. > > Regards, > Kai > > -----Original Message----- > From: Colm O hEigeartaigh [mailto:[email protected]] > Sent: Tuesday, May 09, 2017 8:12 PM > To: [email protected] > Subject: Re: Questions about the release > > I haven't. So I think I should include all "This product contains a > modified portion" portions from the NOTICE file, but not "This product > optionally depends on" from here: > > https://github.com/netty/netty/blob/4.1/NOTICE.txt > > ? As well as any of the licenses that are referred. > > Colm. > > On Tue, May 9, 2017 at 12:46 PM, Emmanuel Lécharny <[email protected]> > wrote: > > > > > > > Le 09/05/2017 à 12:24, Colm O hEigeartaigh a écrit : > > > Thanks Emmanuel. The user would have to add zookeeper/nimbus in the > > > poms before generating the distribution to add them, so I am going > > > to remove these from the NOTICE file as they are not required. > > > > > > OK here are the changes I have made...please review: > > > > > > 1) The root NOTICE just includes the standard Apache copyright notice: > > > > > > https://github.com/apache/directory-kerby/blob/trunk/NOTICE > > > > > > 2) The two "distributions" of "kdc-dist" and "tool-dist" have the > > following > > > NOTICE files: > > > > > > https://github.com/apache/directory-kerby/blob/trunk/ > > kerby-dist/kdc-dist/NOTICE > > > https://github.com/apache/directory-kerby/blob/trunk/ > > kerby-dist/tool-dist/NOTICE > > > > > > and the following identical license folders: > > > > > > https://github.com/apache/directory-kerby/tree/trunk/ > > kerby-dist/tool-dist/licenses > > > https://github.com/apache/directory-kerby/tree/trunk/ > > kerby-dist/kdc-dist/licenses > > > > > > We only bundle Netty + SLF4J in "kdc-dist" and only SLF4J in the > > tool-dist, > > > so I think we are covered. > > > > > > Sounds good to me. > > > > Have you taken into account the transitive dependencies ? (ie, N&L for > > things that are embedded in Netty). > > > > -- > > Emmanuel Lecharny > > > > Symas.com > > directory.apache.org > > > > > > > -- > Colm O hEigeartaigh > > Talend Community Coder > http://coders.talend.com > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
