On 7/9/2025 1:39 AM, Pavel Machek wrote:
In this instance I honestly haven't read the LLM explanation. I agree
with you that the explanation is flawed, but the patch clearly fixes a
problem:
"On AMD dGPUs this can lead to failed suspends under memory
pressure situations as all VRAM must be evicted to system memory
or swap."
So it was included in the AUTOSEL patchset.
Is "may fix a problem" the only criteria for -stable inclusion? You
have been acting as if so. Please update the rules, if so.
I would say that it most definitely does fix a problem. There are
multiple testers who have confirmed it.
But as it's rightfully pointed out the environment that drivers have
during the initial pmops callbacks is different (swap is still available).
I don't expect regressions from this; but wider testing is the only way
that we will find out. Either we find out in 6.15.y or we find out in
6.16.y. Either way if there are regressions we either revert or fix them.
I assume going forward that AUTOSEL will not consider any patches
involving the core kernel and the user/kernel ABI going forward. The
areas I have been involved with over the years, and for which my review
might be interesting.
The filter is based on authorship and SoBs. Individual maintainers of a
subsystem can elect to have their entire subsystem added to the ignore
list.
Then the filter is misdesigned.
BR,
Pavel
