On Tue, Feb 23, 2016 at 7:37 PM, jp charras <jp.char...@wanadoo.fr> wrote:
> Le 23/02/2016 08:56, Cirilo Bernardo a écrit : > > On Tue, Feb 23, 2016 at 3:00 AM, Wayne Stambaugh <stambau...@gmail.com> > > wrote: > > > >> Cirilo, > >> > >> I have one last change request that I missed in my previous review. > >> Please change your debugging output method. Windows apps have no > >> concept of stdout even when run from the command line. wxLogTrace is > >> the preferred method for debugging output. It solves two problems. The > >> debugging strings are redirected to the correct output on all supported > >> platforms and the debugging output is turned off by default. Turning on > >> the debugging output is as simple as: > >> > >> export WXTRACE="SOME_DEBUGGING_OUTPUT_TO_ENABLE" > >> > >> The is handy so I don't have to sift through everyone's debugging output > >> to find what I'm looking for. You just need to pick a unique string not > >> used by any other kicad wxLogTrace calls to enable tracing of your > >> debugging output. > >> > >> > > The 3d_initial_merge branch has been updated to use wxLogTrace; > > it has also been synchronized to the main branch r6527. The latest > > revision for the 3d_initial_merge branch is r6527. The branch builds > > successfully and I have tested the previewer with various VRML1/2 and > > X3D models. > > > > - Cirilo > > Thanks, Cirilo. > Very good work. > > At least on Windows, 3d_plugin_manager.cpp is missing the line: > #include <wx/filename.h> > > Without this include, it does not compile. > > -- > Jean-Pierre CHARRAS > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > Thanks Jean-Pierre, I have added the header and checked that it builds on Windows (W7-64 bit). - Cirilo
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
