Andrzej, I merged your patches. Hopefully this will tamp down some of the layer visibility complaints. Thank you for your contribution to KiCad.
Cheers, Wayne On 2/21/2018 12:44 PM, Andrzej Wolski wrote: > Wayne, > > in attachment all 3 patches I have, rebased. > > Cheers, > Andrzej > > > On 02/21/2018 05:45 PM, Wayne Stambaugh wrote: >> Andrzej, >> >> This patch does not apply cleanly. Please rebase and resubmit it when >> you get a chance. >> >> Thanks, >> >> Wayne >> >> On 2/21/2018 11:27 AM, Andrzej Wolski wrote: >>> Wayne, >>> >>> I have attached that patch to bug report whom which you messaged me, >>> thought you will see it. >>> >>> I'm attaching it again in this email. >>> >>> Cheers, >>> Andrzej >>> >>> >>> On 02/21/2018 05:20 PM, Wayne Stambaugh wrote: >>>> Andrzej, >>>> >>>> You have not replied to my last message about your original patch that >>>> you sent to the developers mailing list[1]. I need that one so I can >>>> apply and test the rest of your layer visibility patches. If you want >>>> these to make it into rc1, please send me this patch as an attachment >>>> soon. I am planning to branch rc1 by Friday at the latest. >>>> >>>> Cheers, >>>> >>>> Wayne >>>> >>>> >>>> [1]: https://lists.launchpad.net/kicad-developers/msg34009.html >>>> >>>> On 2/19/2018 10:05 AM, Andrzej Wolski wrote: >>>>> Patch (in attachment) for "Tracks" turned out to be very simple. >>>>> If it gets accepted, I could make more of these. >>>>> >>>>> Andrzej >>>>> >>>>> >>>>> On 02/19/2018 02:12 PM, Andrzej Wolski wrote: >>>>>> It would be also nice to have separate controls for: >>>>>> 1. Tracks >>>>>> 2. Drawing primitives (graphic lines, arcs, and circles) >>>>>> 3. Zones >>>>>> 4. Polygons >>>>>> 5. Text (now there is control only for footprint text) >>>>>> 6. Dimensions >>>>>> 7. Plated holes >>>>>> >>>>>> That would make Render tab (almost) complete. >>>>>> >>>>>> Andrzej >>>>>> >>>>>> W dniu 2018-02-18 o 21:00, Jon Evans pisze: >>>>>>> Hi all, >>>>>>> >>>>>>> Right now the behavior of the "Layer" and "Render" tabs of the >>>>>>> layers >>>>>>> widget are confusing to users, resulting in complaints on the forum >>>>>>> and some bug reports: >>>>>>> >>>>>>> https://bugs.launchpad.net/kicad/+bug/1748181 >>>>>>> https://bugs.launchpad.net/kicad/+bug/1743890 >>>>>>> >>>>>>> I could take a crack at fixing this (before or after 5.0 >>>>>>> depending on >>>>>>> what the complexity ends up being) but before I write any code I >>>>>>> wanted to propose how I think it should work. >>>>>>> >>>>>>> I think the visibility of any object should be the AND of layer >>>>>>> visibility and render visibility. >>>>>>> >>>>>>> To get there: >>>>>>> >>>>>>> 1) In the Render tab, get rid of the distinction between front/back. >>>>>>> For example "Pads Back" and "Pads Front" becomes just "Pads" >>>>>>> >>>>>>> 2) Change the visibility code so that an object is visible if (a) >>>>>>> the >>>>>>> associated Render setting is turned on for the type of object, and >>>>>>> (b) at least one of the layers the object is on is enabled in the >>>>>>> Layers tab. >>>>>>> >>>>>>> 3) (optionally) Rename "Render" to something more friendly like >>>>>>> "Items" or "Item Types" to make it more clear to the user that this >>>>>>> is where they can turn off the display of various types of items as >>>>>>> opposed to various layerse >>>>>>> >>>>>>> If this plan is OK, I will start working out the details of how to >>>>>>> get there. Right now the Render tab is directly controlling the >>>>>>> visibility of certain "GAL Layers" but unfortunately the set of >>>>>>> objects that appears on one GAL layer is not always equal to the set >>>>>>> of objects that the user would expect to turn on and off, as seen by >>>>>>> the bug reports. So, there will have to be some additional logic >>>>>>> created to manage these settings beyond just turning on and off >>>>>>> layers in the GAL. >>>>>>> >>>>>>> -Jon >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>>> Post to : [email protected] >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>>> More help : https://help.launchpad.net/ListHelp >>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>> Post to : [email protected] >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>> More help : https://help.launchpad.net/ListHelp >>>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> Post to : [email protected] >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
