https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456
--- Comment #71 from Tomás Cohen Arazi <[email protected]> --- (In reply to Lari Taskula from comment #67) > Comment on attachment 135841 [details] [review] > Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es) > > Review of attachment 135841 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Hold/CancellationRequest.pm > @@ +40,5 @@ > > +sub store { > > + my ($self) = @_; > > + > > + if ( !$self->in_storage ) { # new request > > + $self->creation_date( \'NOW()' ) > > Why do we do store() overloading instead of defining "NOT NULL DEFAULT > CURRENT_TIMESTAMP" at table creation? Good catch! This was carried from the first iteration of this dev, in which I added a cancellation request approval workflow, which included an 'updated_on' column which had the trigger set, and as you cannot set it for two columns... Will clean this in a follow-up patch later today! Thanks! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
