https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888
--- Comment #12 from Marcel de Rooy <[email protected]> --- (In reply to Jonathan Druart from comment #11) > We had the discussion for "recalls" and decided to not stick to the current > (wrong) pattern. > > So I don't think this is acceptable, you need to add a new column to the > existing table instead. > > See recalls.completed. > Also bug 19532 comment 5. I just read: Regarding the number of critical issues we had the last few months, I do not think it is a good idea to reuse this pattern. We should not move data from one table to another but add a deleted/old flag instead. Is that a discussion? :) There is a lot of discussion on 20271. And it is open for 6 years already. That is imo not a good argument to block a simple and needed development like this one. I could understand that if you add a NEW table that you should do it as you said. But adding this burden to an EXISTING table is really something else. Adding this 'requirement' effectively kills this development. Can imagine that we could raise serious issues too when we add a flag and forget a few occurrences throughout the whole codebase where we read records from the table. If if would be a requirement, we should have community consensus about it and make it a coding guideline. Which I do not recommend. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
