https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665
--- Comment #10 from Jonathan Druart <[email protected]> --- 1. At least since bug 35918 we took care of having the selected library at the beginning on the array and so this library will be picked first if matched. I think we should improve the syspref's description to clarify what "first" really means here. For discussion: shouldn't we list patron's library as well? uniq(selected_library, patron's library, other libraries) 2. I think AutoLocation should be renamed, we are adding more confusion about its purpose with this new syspref. 3. We should have all this code inside a `if ($type ne 'opac')` block. It seems that we don't use this branch or branchname TT var in the OPAC but it would be better to not pass it at all it seems (existed prior to this patch). I understand that you consider this critical and that you even bypass proper QA but maybe those remarks can be addressed on a separate bug, or at least we need plans for the next steps? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
