https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665
--- Comment #12 from Nick Clemens (kidclamp) <[email protected]> --- (In reply to Jonathan Druart from comment #10) > 1. At least since bug 35918 we took care of having the selected library at > the beginning on the array and so this library will be picked first if > matched. I think we should improve the syspref's description to clarify what > "first" really means here. > For discussion: shouldn't we list patron's library as well? > uniq(selected_library, patron's library, other libraries) Looking into the code, it seems 35918 uses the patron's library OR the selected library first, but it looks like the rest of the array is still taken unordered from the hash? I will file a follow-up bug for this > > 2. I think AutoLocation should be renamed, we are adding more confusion > about its purpose with this new syspref. We have bug 26176 open for this, I will look into supplying a patch > 3. We should have all this code inside a `if ($type ne 'opac')` block. It > seems that we don't use this branch or branchname TT var in the OPAC but it > would be better to not pass it at all it seems (existed prior to this patch). That makes sense, I went about restoring the previous functionality as closely as possible, but can provide a follow-up here to wrap the opac test around all the code > I understand that you consider this critical and that you even bypass proper > QA but maybe those remarks can be addressed on a separate bug, or at least > we need plans for the next steps? I am not sure what steps here bypassed proper QA? A QA team member signed off the bug - we then got a sign off from a community member (we attached the sign off as they had issues using the sandboxes) and upgraded, with their permission, the QA team members SO to QA. That discussion could have been included on the bug, but I thought it was straightforward enough to simply reorder the sign offs. I will file to follow-ups, but if you think this needs more attention feel free to change the status. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
