https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38204
--- Comment #9 from Matt Blenkinsop <[email protected]> --- (In reply to Jonathan Druart from comment #8) > 1. Why do you make the basket's name not null? > name: > - type: string > + type: > + - string > + - "null" > > It can be NULL at DB level, but the UI is enforcing it. I think we should > keep the constraint at the REST API level. I can reset this and do checks in the controller > 2. > create_items: > - type: string > + type: > + - string > + - "null" > Same, why allowing null here? In the description for create_items it says "When items should be created for orders in this basket (Options: 'ordering', 'receiving', 'cataloguing'. Null means system wide config)". Null is supposed to be allowed as an option but the endpoint crashes if it is set to null as we don't allow null to be passed > 3. > - authorised_by: > + creator_id: > > It has been there for a while now, isn't it a problem to modify it, > especially without advertising it. There may be existing consumers. How does this work with the to_api_mapping? That maps authorisedby to creator_id which suggests there would be conflict? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
