https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38204
--- Comment #15 from Tomás Cohen Arazi (tcohen) <[email protected]> --- (In reply to Matt Blenkinsop from comment #13) > > The nullable option does work in the spec, I've tested it. I think if we had > a "system_wide" option it should match the AcqCreateItem syspref. Having > said that we don't currently have a POST/PUT endpoint for baskets so its > only relevant for listing them currently As y'all have noticed, even if there was no baskets endpoint, I added a spec and stuff for being able to embed them. In this case, we don't have POST or PUT, but when time comes (probably soon?) we don't want to change the spec again. I'd be in favor of even refactoring the nullable nature of the field in the DB, which makes us have to deal with it here, adding technical debt. It would mean just changing some: ```perl if (!$basket->create_items) { } ``` for ```perl if ( $basket->create_items eq 'system_wide' ) { } ``` -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
