https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38204

--- Comment #13 from Matt Blenkinsop <[email protected]> ---

> > > 2. 
> > >    create_items:
> > > -    type: string
> > > +    type:
> > > +      - string
> > > +      - "null"
> > > Same, why allowing null here?
> > 
> > In the description for create_items it says "When items should be created
> > for orders in this basket (Options: 'ordering', 'receiving', 'cataloguing'.
> > Null means system wide config)". Null is supposed to be allowed as an option
> > but the endpoint crashes if it is set to null as we don't allow null to be
> > passed
> 
> I don't like enum fields to not be advertised as such in the spec. But I'm
> not sure how's that gonna work with the 'nullable' option. You should try.
> And maybe add a 'system_wide' option that would map to NULL on its way to
> the DB.

The nullable option does work in the spec, I've tested it. I think if we had a
"system_wide" option it should match the AcqCreateItem syspref. Having said
that we don't currently have a POST/PUT endpoint for baskets so its only
relevant for listing them currently

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to