https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664
--- Comment #7 from Pedro Amorim <[email protected]> --- (In reply to Jonathan Druart from comment #4) > This is a priority for me because of the number of commits dealing with > tidying: > > % git log --oneline v24.05.00..HEAD|grep -i tidy|wc -l > 80 > > We lose time during QA. These are tidy patches on top of submissions, tidying the whole code won't stop these. New submissions will potentially continue to be submitted with untidy code and tidy fixes will still continue to exist to address these. Squashing tidy fixes into the original patch is what will stop these. Correct me if I'm wrong please in case I'm missing the point. As I said, I'm not against it, I just don't see how tidying the whole codebase is fixing any problem. (In reply to Paul Derscheid from comment #5) > This might be personal to me, but I think we also lose time in dev. > Uniformly formatted code is easier to scan in my opinion. > > Also we don't need to format ranges anymore and can straight go to format on > save. I've been using format on paste. Cut whatever new code I wrote and paste -> its tidy. I'm okay being in the minority here, just giving my opinion as it was asked! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
