https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664
--- Comment #8 from Jonathan Druart <[email protected]> --- (In reply to Pedro Amorim from comment #7) > (In reply to Jonathan Druart from comment #4) > > This is a priority for me because of the number of commits dealing with > > tidying: > > > > % git log --oneline v24.05.00..HEAD|grep -i tidy|wc -l > > 80 > > > > We lose time during QA. > > These are tidy patches on top of submissions, tidying the whole code won't > stop these. New submissions will potentially continue to be submitted with > untidy code and tidy fixes will still continue to exist to address these. > Squashing tidy fixes into the original patch is what will stop these. > Correct me if I'm wrong please in case I'm missing the point. > > As I said, I'm not against it, I just don't see how tidying the whole > codebase is fixing any problem. See comment 6. With a pre-commit hook you don't need to care about tidying at all. Just code and commit. With everybody using the hook we ensure that the code stays tidy. For that we need a starting point where everything is tidy. Regular contributors won't submit code that is not tidy as they are using ktd with the git hook installed automatically. On top of that, add a QA check (if someone forgets to setup the hook) and a xt test (if QA+RM forgets to run the QA script), and the code stays tidy, forever :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
