https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664
--- Comment #11 from Julian Maurice <[email protected]> --- > On top of that, add a QA check (if someone forgets to setup the hook) and a > xt test (if QA+RM forgets to run the QA script), and the code stays tidy, > forever :) If it is only caught by the xt test, then it means the main branch is not tidy (I assume the test is run by Jenkins, not by RM). So perltidy will still need to be run from time to time ? Not a big deal for me, I prefer having a code base 100% tidy most of the time than the current state. Side note: are you considering using https://pre-commit.com/ ? I think it would be handy when dealing with multiple dev installs, and it would be easier to update/add new hooks if needed. > perltidy doesn't always work. Sometimes it fails and you end up with inline > error messages. I've seen it failed too, but only if given invalid/incomplete Perl code (a range of lines ending in the middle of an if-block for instance). Can it fail on valid Perl code ? Another advantage I see is that the QA script won't need to run perltidy test on the first pass, so it should speed things up a little bit. (off-topic: it would be great if we didn't need that 1st pass at all: no need to commit, and cleaner git reflog) > * provide a script to ease rebases You got me curious there... Do you have a magic spell or something ? :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
