https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334

--- Comment #99 from Victor Grousset/tuxayo <[email protected]> ---
Comment on attachment 176023
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176023
Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items

Review of attachment 176023:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37334&attachment=176023)
-----------------------------------------------------------------

::: Koha/Item.pm
@@ +1469,5 @@
> +    if ( $self->damaged ) {
> +        push @statuses, 'damaged';
> +    }
> +    if ( $self->notforloan || $self->item_type->notforloan  ) {
> +        # TODO on a big Koha::Items loop we are going to join with item_type 
> too often, use a cache

Is the concern big enough to at least have a ticket opened to measure this? And
eventually implement a cache.

@@ +1487,5 @@
> +    if ( $self->restricted ) {
> +        push @statuses, 'restricted';
> +    }
> +
> +    # TODO in_bundle?

Was that meant to be temporary or does it have a long term use?
Does it warrant at least opening a follow-up ticket or it's too minor?
Does it warrant some manual testing related to bundles?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to