https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334
Victor Grousset/tuxayo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Signed Off |Failed QA --- Comment #101 from Victor Grousset/tuxayo <[email protected]> --- To pass the tests, only these two commits are needed: Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items Bug 37334: Restore filtering holdings per status Looking the diffs of the other commits, there are substantial changes that would have been expected to be necessary for tests to pass. After that smoke test, let's look at proper coverage: https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17:_Unit_tests_are_required These are not covered by tests: sub filter_by_has_recalls sub filter_by_available search() have very little coverage. At least having the most complex case (not_for_loan) covered would be safer. The "recalled" and "available" cases would also cover the above paragraph. Or maybe they should be tested directly and not via search(). No opinion on this. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
