https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334
--- Comment #100 from Lucas Gass (lukeg) <[email protected]> --- (In reply to Victor Grousset/tuxayo from comment #99) > Comment on attachment 176023 [details] [review] > Bug 37334: Allow embed _status for GET /biblio/{biblio_id}/items > > Review of attachment 176023 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Item.pm > @@ +1469,5 @@ > > + if ( $self->damaged ) { > > + push @statuses, 'damaged'; > > + } > > + if ( $self->notforloan || $self->item_type->notforloan ) { > > + # TODO on a big Koha::Items loop we are going to join with > > item_type too often, use a cache > > Is the concern big enough to at least have a ticket opened to measure this? > And eventually implement a cache. Yes, we should open a new bug report for this. > @@ +1487,5 @@ > > + if ( $self->restricted ) { > > + push @statuses, 'restricted'; > > + } > > + > > + # TODO in_bundle? > > Was that meant to be temporary or does it have a long term use? > Does it warrant at least opening a follow-up ticket or it's too minor? > Does it warrant some manual testing related to bundles? in_bundle is a status, so that needs to be included in this bug, I think. I will add ASAP. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
