https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350
--- Comment #19 from David Gustafsson <[email protected]> --- Now things should work again. Had to make somewhat dramatic changes though, but personally I think they are for the better. I moved the code Koha/Obects.Mixin/ExtendedAttributes.pm to the Koha::Objects class instead. The mixin replaced the search method, does it's thing, and then re-implements what Koha::Objects->search does, which is not very nice. I think I know why since it can't call $self->SUPER::search since Koha::Objects a sibling class of the mixing, not a parent, and thus can't be accessed. I'm personally not a fan of mixins and multiple inheritence in Perl since it creates these kind of confusing situations and ugly workarounds. I also removed use base qw(Koha::Objects::Mixin::ExtendedAttributes); from Koha/Objects/Mixin/AdditionalFields.pm. The mixin is not need anymore since included in Koha::Objects, and I don't see why it should inherit from Koha::Objects when used as a mixin, it doesn't uses SUPER, and if it did it would probably not work as expected. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
