https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350
--- Comment #29 from David Gustafsson <[email protected]> --- (In reply to David Cook from comment #20) > Overall, I'm quite intrigued, although I think it'll be easier for you to > get this through if you just start with 1 thing first (ie just ItemTypes or > just Libraries), so that it's easier to review and test. > > While I like the idea of caching data and reducing DB calls in theory, > widespread unintended consequences are scary... I agree this the change is a bit scary, and could possibly cause issues even though the cache expiration logic should in theory be exhaustive enough there could be cases where it is bypassed by using methods on _resultset directly. There is also the case where find is used internally in some class on objects where a reference exists outside of the class mutating the shared object causing unexpected issues. In theses cases care must be taken to use uncached calls to prevent this from happening. I have reviewed the code and believe I have caught all theses cases, but one can never be 100% sure. We will be using this patch in production for our next release, and since we have quite a large instance using most features in Koha I'm fairly confident any possibly remaining bugs not covered by the tests will be caught. So I recommend postponing merging before we have tested this in production for a while. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
