https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350
--- Comment #31 from David Gustafsson <[email protected]> --- (In reply to David Cook from comment #25) > Could you talk more about "This patch enables caching for ItemTypes and > Libraries which I believe are called repeatedly for the same objects much > than the others"? > > Do you mean that $obj1 calls something like libraries() repeatedly and each > call fetches the libraries again? > > Or that $obj1, $obj2, $obj3, etc all call libraries() and thus send the same > DB query needlessly? I think cache is skipped in cases where search is called on an existing result-set since these cases are not possible to cache using arguments only as cache key. But there are lots of instances where search or find is called repeatedly with the same ids/query, some of which have custom local caching, some of which we previously added custom local caching which can be replaced by this. I believe I previously reviewed the entire code base and came to the conclusion that practically all cases where this is an issue is address by caching the objects for which caching has been added in this patch. So I believe there is currently little to gain by adding caching for any more Koha object types. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
