https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40174

--- Comment #7 from Jonathan Druart <[email protected]> ---
(In reply to David Nind from comment #6)
> Created attachment 183851 [details]
> Bug 40174 (and related bugs) - Test failues.txt
> 
> I tested the bug_40180 branch from your repository.
> 
> This is how I tested things:
> 1. Added the remote: git remote add joubu https://gitlab.com/joubu/Koha
> 2. Fetched the remote: git fetch joubu
> 3. Checked out the branch from the remote: git checkout -b bug_40180
> joubu/bug_40180
> 4. yarn build
> 5. restart_all (maybe this should be a reset_all?)

Yes, `reset_all` or `yarn api:bundle && restart_all`

> 6. Enabled the RESTBasicAuth system preference.
> 7. Ran individual tests for the dependent and related bugs - see [1] for the
> list
> 8. Ran all the cypress tests: perl /kohadevbox/misc4dev/run_tests.pl
> --run-cypress-tests-only
>    - ERM/DataProviders_spec.ts and ERM/UsageReports_spec.ts failed, but I
> think they've been fixed now
>    - KohaTable/Holdings_spec.ts sometimes failed for me [2]
>    - KohaTable/KohaTable_spec.ts sometimes failed for me [3]

I think there are failing because you have not rebuilt the swapper spec (`yarn
api:bundle` then restarted plack, or `reset_all`).
In theory they could still fail, but with way less reproducibility (without the
 spec regenerated, branchcodes are generated using only 1 letter, and it
clashes if it starts with the first letter of an existing library (eg. C and
CPL in your case). With the new changes it will be 10 letters long and we won't
have such clashes.

> 9. The tests related to bugs 40301 and 40320 failed for me.

I would suggest to have the first batch (up to bug 40181) pushed before we
focus on the other ones :)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to