https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893
Pedro Amorim <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://github.com/openfift |https://github.com/openfift |h/koha/commits/new_bug_3789 |h/koha/commits/final_bug_37 |3 |893 Status|Failed QA |Needs Signoff --- Comment #42 from Pedro Amorim <[email protected]> --- Hi all, I've revisited this: - A third rewrite has been done on the module to adhere to the patterns introduced by pushed bug 38201 (VueJS composition API, etc) - Server params and listeners have been removed from the UI module and are kept in SIPConfig.xml as per QA comments by David Cook. - Cache is now utilized to check for the last time an account, an institution or a system preference override has been updated. When a new SIP request comes in, it checks if SIP configuration has been updated and does a new read from the database if so. This allows for changes that are made by the UI to reflect on the SIP server without needing a server restart. QA script complaints: - Files were added+removed in the same patch. This refers to the server params+listeners functionality that once existed but has since been purged. - The above happens because I've opted to not squash any patches. This project has gone for over a year (on and off) and contains a patch co-authored by Martin Renvoize and a patch co-authored by Mark Hofstetter. - Some database columns are tinyint but not boolean: lost_block_checkout, lost_block_checkout_value, lost_status_for_missing. These are false positives as these are all intentionally tinyint not boolean. - I believe errors on SIPServer.pm related to pod_coverage are false positives coming from old methods that have non-conformant pod code, not by code added on this patchset. Test plan remains the same. However, because many code changes have happened, I'm asking those who tested before to please test again when convenient. Test plan for the whole module: [MODULE UI TESTING] 1) Checkout the branch and reset_all 2) Run 'updatedatabase'. The contents from /etc/koha/sites/kohadev/SIPConfig.xml have been migrated to the database and should be accessible in the UI. 3) Visit the administration page: http://localhost:8081/cgi-bin/koha/admin/admin-home.pl 4) Notice the new 'Self-service circulation (SIP2)' item under 'Patrons and circulation'. Click it. 5) Notice you are now on the new SIP2 module. Create some institutions, accounts, listeners, etc. Play around with the forms. 6) Confirm all the data has been migrated correctly, and is editable in the UI as expected. [SIP TESTING] 1) On ktd, run the following SIP emulator command: $ perl misc/sip_cli_emulator.pl -su koha -sp koha -l kohalibrary --host localhost --patron 42 -m patron_information 2) Note that the response message contains 'Greetings from Koha'. 3) Using the module UI, visit SIP accounts: http://localhost:8081/cgi-bin/koha/sip2/accounts 4) Find the SIP account that has 'koha' as login. Click edit. 5) Scroll down to 'SIP response mappings' and click 'Add new screen msg regex'. 6) On 'Find', enter 'Greetings from Koha'. On 'Replace', enter 'Hello from 37893 test plan'. Save. 7) Repeat the sip command from 1). Note that 'Greetings from Koha has been replaced with 'Hello from 37893 test plan', without having to restart the SIP server. [OPTIONAL] 1) You can repeat the previous steps in [MODULE UI TESTING] but edit the contents of /etc/koha/sites/kohadev/SIPConfig.xml beforehand with a more complex and thorough configuration (something resembling a real SIPConfig.xml) 2) After updating the contents of SIPConfig.xml, restart SIP: koha-sip --restart 3) Test the module again, verify the contents have been migrated as expected. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
