https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43576

--- Comment #20 from Martin Renvoize (ashimema) 
<[email protected]> ---
Created attachment 206383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206383&action=edit
Bug 43576: (follow-up) Stretch the sidebar to the actual viewport bottom

The previous patch only made the sidebar match its sibling column's
height, which does nothing on the very common case where neither
column has enough content to reach the bottom of the browser window --
the whole .row simply shrink-wraps to whatever short content exists.

Make body a min-height:100vh flex column (Bootstrap's own documented
sticky-footer/full-height pattern: display:flex, flex-direction:column,
min-height:100vh, with the main content area set to flex:1 0 auto),
with .main.container-fluid and its .row set to flex: 1 0 auto so they
grow to fill the remaining space below the header/nav and above the
existing body padding-bottom that already clears the fixed
#changelanguage bar.

Vue SPA modules (ERM, ILL, Preservation, SIP2, Acquisitions/vendors)
render their own main-container-equivalent markup nested inside a
per-app root div (#erm, #sip2, etc.) rather than main-container.inc
being a direct child of body, with an extra unstyled wrapper div (the
Vue root template's own top-level element) in between. Both of those
need the same flex treatment to pass the stretch all the way down to
.main.container-fluid.

Verified across short and long pages, with and without a sidebar, for
both classic TT pages and all Vue SPA modules, at various viewport
heights.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to