https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503

--- Comment #125 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
Created attachment 208130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208130&action=edit
Bug 42503: Show translated item type in the holds queue

The holds queue "Item type" column displayed a single materialized,
default-language description. This makes it show the translated item
type description according to the staff interface language.

To do this the item type *code* is now materialized on tmp_holdsqueue
(new `itype` column, FK to itemtypes), and the translated description is
resolved through the standard `+strings` API embed convention:

- tmp_holdsqueue gains an `itype` column (varchar(10)) with a foreign
  key to itemtypes(itemtype) (ON DELETE SET NULL / ON UPDATE CASCADE),
  added via kohastructure.sql and an idempotent atomic update.
- Koha::Hold::HoldsQueueItem gains a strings_map() implementing the
  `+strings` convention for `itype` (translated_description), and maps
  itype => item_type_id in to_api_mapping.
- The holds_queue_item API definition exposes item_type_id and _strings.
- C4::HoldsQueue populates `itype` when building the queue and filters on
  the joined item.itype/item.ccode/item.location columns.
- The holds queue template renders the column from
  _strings.item_type_id.str, falling back to the materialized
  itype_description. Sorting/filtering is on the item type code; sorting
  by translated description is left as a follow-up.

Test plan:
1. Apply the atomic update (updatedatabase.pl).
2. Translate an item type description (Administration > Item types >
   "Translate into other languages") into a non-default language.
3. Rebuild the holds queue (build_holds_queue.pl) with items of that type.
4. View the holds queue in the staff interface in that language.
   => The Item type column shows the translated description.
5. prove t/db_dependent/HoldsQueue.t t/db_dependent/api/v1/holds_queue.t

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to