https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503
--- Comment #123 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 208128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208128&action=edit Bug 42503: (follow-up) Restore publication details fields in holds queue The API-driven holds queue 'Publication details' column regressed when the page was converted to use DataTables. The original view_holdsqueue.tt rendered edition statement, publisher, publication year (falling back to the copyright date), pages, material size and ISBN. The new render function only emitted edition statement, publisher and publication year. This patch restores the missing fields in the column render function. All the required data is already available on the embedded biblio object, so no API or embed change is needed. Changes: - koha-tmpl/.../circ/holds_queue.tt: rebuild the publication details string to include: - copyright_date fallback when publication_year is empty - pages (prefixed with ': ') - material_size - isbn (as 'ISBN: ...') - No functional change to the API or the embed set Test plan: 1. Apply all patches for this bug 2. Make sure a biblio in the queue has pages, size, ISBN and a copyright date but no publication year 3. Populate the holds queue: $ ktd --shell k$ perl t/lib/sample_holds_queue.pl 4. Navigate to Circulation > Holds queue and look at the 'Publication details' column => FAIL: Only edition, publisher and year are shown. Pages, size, ISBN and the copyright date fallback are missing 5. Apply this patch 6. Rebuild assets and reload the page: k$ yarn build 7. Repeat step 4 => SUCCESS: Pages, size, ISBN and the copyright date fallback are shown again, matching the previous behaviour 8. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
