https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503

--- Comment #127 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
(In reply to Pedro Amorim (ammopt) from comment #110)
> Hi all, 3 blockers here that should be easy to fix:
> 
> Setup:
> 1) Apply the patches, then: updatedatabase && yarn build && restart_all
> 2) Populate the queue: perl t/lib/sample_holds_queue.pl
> 3) Open http://localhost:8081/cgi-bin/koha/circ/holds_queue.pl?run_report=1
> 
> Blocker 1: patron name ignores preferred name
> 1) Pick a patron in the queue and edit them: set 'Preferred name' to
> something different from 'First name'.
> 2) Reload the holds queue. The patron shows as "Surname, Firstname" with no
> card number. Before the patches it showed "Surname, Preferredname
> (cardnumber)".

Good catch! I fixed it and ran two instances in parallel to compare. Solved
now!

> Blocker 2: patrons from other libraries show an empty cell
> 1) Log in as a staff user from another library with only 'catalogue' and
> 'circulate_remaining_permissions' (no
> 'view_borrower_infos_from_any_libraries').
> 2) Open the holds queue. The patron cell is empty. Before the patches it
> said "A patron from library <name>".

Correct. Same as the above, solved!

> Blocker 3: publication details are trimmed
> 1) Look at the 'Publication details' column for a record with an ISBN or
> pages. Only edition, publisher and year are shown. Before, it also showed
> pages, size and ISBN, and fell back to the copyright date when there was no
> publication year.

Yeah, solved!

> Not blockers, but worth a follow-up bug and/or the release notes:
> 
> Non-blocker 1: item types aren't translated
> 1) Install French in the KTD shell (takes a few minutes):
>    cd /kohadevbox/koha/misc/translator && perl translate install fr-FR
> 2) In 'Administration' > 'System preferences', search for
> 'StaffInterfaceLanguages', tick 'Français (fr-FR)' and save.
> 3) Go to 'Administration' > 'Item types' and edit 'Books'. Next to
> 'Description', click 'Translate into other languages', add "Livres" for
> fr-FR, and save.
> 4) Switch the staff interface to Français using the language selector at the
> bottom of the page.
> 5) Open http://localhost:8081/cgi-bin/koha/circ/holds_queue.pl?run_report=1.
> The item type column still shows "Books".
> 6) Open any record with a Books item, e.g. one from the queue. Its holdings
> table shows "Livres", which is what the holds queue showed before the
> patches.

I will file a follow-up bug. It seems that when the translatability feature was
pushed no one thought about the API/+strings use case and sorting. We will want
a generic implementation I'd say. The hard part being the fallback when some
cases don't have a translation and other do.

> Non-blocker 2: old URL is gone
> 1) Open http://localhost:8081/cgi-bin/koha/circ/view_holdsqueue.pl. It
> returns 404. People bookmark this page, so worth a mention in the release
> notes.

Do you think it is worth restoring the original name?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to