https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383

--- Comment #67 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
Created attachment 209618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209618&action=edit
Bug 42383: (QA follow-up) Print the recall pickup slip for recalls

The 'Print slip and confirm (P)' button of the recall modal used
recallInfo.reserve_id (falling back to the checkin hold_id) to load
the hold transfer slip. The recall_found message payload only contains
recall_id and needs_transfer, so no slip was ever printed, or the
wrong one was. The legacy page opened
recalls/recall_pickup_slip.pl?recall_id=X.

This patch (QA comment point 7) adds a recallSlipUrl() helper to
slip-printer.js and makes the button load the recall pickup slip for
the payload recall_id, once the recall has been confirmed (same as the
hold slip).

Test plan:
1. Enable UseRecalls and set up circulation rules allowing recalls
2. Check an item out to patron A, then place a recall on it for
   patron B from the OPAC
3. Check the item in on the check-in page
=> SUCCESS: The recall modal is displayed
4. Click 'Print slip and confirm (P)'
=> FAIL: No slip, or an empty / wrong slip, is displayed
5. Apply this patch and rebuild:
   $ ktd --shell
  k$ yarn js:build
  k$ restart_all
6. Repeat steps 2 to 4 with a new item
=> SUCCESS: The recall is confirmed and the recall pickup slip for
   patron B is displayed in a popup
7. Sign off :-D

Assisted-by: Opus 5.5 (Anthropic)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to