https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383

--- Comment #74 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
Created attachment 209625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209625&action=edit
Bug 42383: (QA follow-up) Do not return $__ from the check-in components

The check-in components returned the $__ translation function from
setup(). Vue reserves the '$' prefix for its internals and logs a
warning on each mount in development builds:

    [Vue warn]: setup() return property "$__" should not start with "$"
    or "_" which are reserved prefixes for Vue internals.

The function is already available to the templates as a global
property, registered by the @koha-vue/i18n plugin the check-in app
uses. This patch removes it from the setup() return values of the
Circ/Checkin components. The Cypress support file fails the tests on
any console warning, so this was making the check-in page Cypress tests
fail.

Test plan:
1. Run:
   $ ktd --shell
  k$ yarn js:build
2. Open the browser console and go to Circulation > Check in
=> FAIL: The Vue warning about "$__" is logged
3. Apply this patch, repeat 1 and 2
=> SUCCESS: No warning
4. Check in some items, open the settings panel
=> SUCCESS: All the strings are displayed as before
5. Sign off :-D

Assisted-by: Opus 5.5 (Anthropic)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to