https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43340
--- Comment #29 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 210747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210747&action=edit Bug 43340: (QA follow-up) Name and pin the check for a temporary SMTP failure Email::Sender::Transport::SMTP gives a failure to connect, including a 421 before EHLO, no response code and no exception class of its own, so the only way to recognise it is its message. That match sat inline in the catch block, undocumented, and would have turned retries back into permanent failures without a sound if the wording ever changed. Move the decisions into _is_temporary_smtp_failure and _is_smtp_server_unavailable, document where the message comes from and that a misconfigured host is retried until the retries run out, and add a test that provokes the failure from the real transport so that a change in Email::Sender's wording is caught. The catch block also takes a copy of the exception before it calls anything else, rather than reading $_ after DBI calls. Test plan: 1. prove t/db_dependent/Letters.t Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
