https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43340

--- Comment #21 from Martin Renvoize (ashimema) 
<[email protected]> ---
Created attachment 210739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210739&action=edit
Bug 43340: Token delivery endpoint never responds if the OTP message is left
pending

The send_otp_token controller queues the 2FA_OTP_TOKEN notice, sends it
right away with SendQueuedMessages, and then only renders a response if
the message ended up 'sent' or 'failed'. A message that is still
'pending' renders nothing at all, so the request hangs until Mojolicious
gives up on it. That is what SendQueuedMessages leaves behind when a
message domain limit defers the message, and what the following patches
leave behind after a temporary SMTP failure.

This patch makes the controller treat anything other than 'sent' as not
sent and respond with a 400 email_not_sent.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/api/v1/two_factor_auth.t

Signed-off-by: Brendan Lawlor <[email protected]>
Signed-off-by: Martin Renvoize <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to