-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/59/#review91
-----------------------------------------------------------



/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.cpp
<http://reviewboard.kde.org/r/59/#comment55>

    Please use a static const int in the .cpp file for this instead of a magic 
number.


- Matt


On 2009-02-12 16:10:30, Benson Tsai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/59/
> -----------------------------------------------------------
> 
> (Updated 2009-02-12 16:10:30)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> This patch splits consecutive message if they are more than 15 minutes apart. 
> This is useful because currently it is hard to tell what time a message is 
> sent if it were consecutive aside from the date of the first consecutive 
> message which could be easily hours, days, or even months (because of history 
> messages!).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.cpp 925222 
> 
> Diff: http://reviewboard.kde.org/r/59/diff
> 
> 
> Testing
> -------
> 
> I'm using the patch and it does indeed break up messages more than 15 minutes 
> apart.
> 
> 
> Thanks,
> 
> Benson
> 
>

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to