----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/59/#review95 -----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.cpp <http://reviewboard.kde.org/r/59/#comment67> This is nitpicking a bit, but I would prefer ConsectutiveMessageTimeout so just upper case the c and it'll be fine. This is so we can tell that's it's constant rather than a variable. - Matt On 2009-02-13 07:35:20, Benson Tsai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/59/ > ----------------------------------------------------------- > > (Updated 2009-02-13 07:35:20) > > > Review request for Kopete. > > > Summary > ------- > > This patch splits consecutive message if they are more than 15 minutes apart. > This is useful because currently it is hard to tell what time a message is > sent if it were consecutive aside from the date of the first consecutive > message which could be easily hours, days, or even months (because of history > messages!). > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.cpp 925222 > > Diff: http://reviewboard.kde.org/r/59/diff > > > Testing > ------- > > I'm using the patch and it does indeed break up messages more than 15 minutes > apart. > > > Thanks, > > Benson > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
