On Monday 07 August 2017 09:34:37 Pali Rohár wrote: > On Monday 07 August 2017 07:52:39 vijay krishnavanshi wrote: > > Hi, > > > > I am fixing the raised issues in old review requests so how do I submit the > > changes for review. Should I create a new review request addressing all the > > issues or create a separate review request for each old review request? or > > comment on the old review request for the changes? > > > > Regards, > > Vijay Krishnavanshi > > Hi! Choose solution which you like most. Ideally write comments to open > issues either with proposed fix or with link to patch or a new request. > > I would then either apply fix for current review request or take a new > patch from a new review request. > > Anyway, I rebased kf5 branch on top of master with (semi-manual) > conflicts resolution and found out that changes between kf5 branch and > "kf5 rebased on top of master" differs. And I suspect that some merge > commits which was done from master to kf5 were incorrectly. > > I will push that new branch (kf5 rebased on top of master) to kopete git > repository under name master-kf5, so we would be able to compare and fix > possible problems...
New branch master-kf5 is in my cloned repository, available at: https://cgit.kde.org/clones/kopete/pali/kopete.git/log/?h=master-kf5 diff between kf5 and my master-kf5 show some changes, so these needs to be investigated. Specially history plugin and jabber protocol. PS: If you do not see that cloned repository yet, just wait as at time of writing this email it was not synced to all kde git mirrors... -- Pali Rohár pali.ro...@gmail.com
