Unfortunately, this makes confirming the installed version impossible. If I
download r10535 and it reports it is r10529, that is confusing to the user.
We also use the number on http://download.openlaszlo.org/nightly/trunk/10535
to make the tag. If no changes got checked in between 10529 and 10535 what
is the harm? A quick 'svn diff -r 10529:10535' can tell you that no changes
were checked in.
Mamye
----- Original Message -----
From: "P T Withington" <[EMAIL PROTECTED]>
To: "Mamye Kratt" <[EMAIL PROTECTED]>
Cc: "Laszlo-dev bug reporting" <[email protected]>
Sent: Thursday, July 31, 2008 1:23 PM
Subject: Re: I know the windows and mac builds are failing...
On 2008-07-31, at 14:56EDT, Mamye Kratt wrote:
r10535, http://download.openlaszlo.org/nightly/trunk/10535, is
reporting 10529 on OS X, XP and Linux.
That is correct.
The 'build number' (the filename of the build on the build machines and
on the download page) is created by creating a tag for the build, which
increments the svn version number. Actually, there must be 2 check-ins
triggered by a build, because each time you run a build, the build number
increments by 2.
But the 'build ID', the thing that I want to appear in the
versionInfoString, is computed by asking svn: "What is the last change
that was made in the branch that I am building?". And, for trunk, as of
this morning, that change is 10529. For the 'build ID' I concatenate the
svn revision with the branch name; from that you can determine the state
of the source that was used to create the build.
If you have multiple builds with no intervening checkins to the branch
being built, the 'build ID' will not change. (The tags that the build
system creates go in the tags branch, so do not affect the being built
branch.) Because it is true that the build system itself may have
changed between builds from identical sources, we _might_ want to add
something about that, but for now, the 'build date' seems sufficient to
distingush different builds of the same source.
